FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: remove unnecessary V8 flag by aduh95 · Pull Request #37671 · nodejs/node · GitHub

/ node Public

test: remove unnecessary V8 flag - #37671

Merged
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:weak-ref-harmony
Mar 9, 2021
Merged

test: remove unnecessary V8 flag#37671
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:weak-ref-harmony

Conversation

aduh95 commented Mar 9, 2021

Copy link
Copy Markdown
Contributor

I'm trying to remove the flag upstream.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/2741582

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 9, 2021
aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 9, 2021

aduh95 commented Mar 9, 2021

Copy link
Copy Markdown
Contributor Author

fast-track?

aduh95 removed the needs-ci PRs that need a full CI run. label Mar 9, 2021
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/2741582

PR-URL: nodejs#37671
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
aduh95 force-pushed the weak-ref-harmony branch from 2080989 to 5247dc0 Compare March 9, 2021 15:21

aduh95 commented Mar 9, 2021

Copy link
Copy Markdown
Contributor Author

Landed in 5247dc0

aduh95 merged commit 5247dc0 into nodejs:master Mar 9, 2021
aduh95 deleted the weak-ref-harmony branch March 9, 2021 15:24
aduh95 added a commit to aduh95/node that referenced this pull request Mar 15, 2021
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/2741582

PR-URL: nodejs#37671
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/2741582

PR-URL: #37671
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
targos pushed a commit that referenced this pull request May 1, 2021
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/2741582

PR-URL: #37671
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
danielleadams mentioned this pull request May 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL