FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

crypto: reconcile duplicated code by jasnell · Pull Request #37704 · nodejs/node · GitHub

/ node Public

crypto: reconcile duplicated code - #37704

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:reconcile-crypto-dup-code
Closed

crypto: reconcile duplicated code#37704
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:reconcile-crypto-dup-code

Conversation

jasnell commented Mar 11, 2021

Copy link
Copy Markdown
Member

/cc @panva

Signed-off-by: James M Snell jasnell@gmail.com

Signed-off-by: James M Snell <jasnell@gmail.com>
nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Mar 11, 2021

This comment has been minimized.

This comment has been minimized.

panva added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. and removed needs-ci PRs that need a full CI run. labels Mar 11, 2021

This comment has been minimized.

This comment has been minimized.

nodejs-github-bot commented Mar 11, 2021
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36618/ 💚

panva commented Mar 13, 2021

Copy link
Copy Markdown
Member

Landed in e76d762

panva closed this Mar 13, 2021
panva pushed a commit that referenced this pull request Mar 13, 2021
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #37704
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #37704
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #37704
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL