assert,util: fix commutativity edge case - #37711
Merged
aduh95 merged 1 commit intoMar 13, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
benjamingr
approved these changes
Mar 11, 2021
lpinca
approved these changes
Mar 11, 2021
aduh95
approved these changes
Mar 11, 2021
Trott
approved these changes
Mar 11, 2021
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Verify that both objects property keys are enumerable. Fixes: nodejs#37710 PR-URL: nodejs#37711 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
aduh95
force-pushed
the
fix-comparisons-communtativity
branch
from
9248e4d to
5ff2e58
Compare
March 13, 2021 12:44
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verify that both objects property keys are enumerable.
Fixes: #37710