doc: recommend checking abortSignal.aborted first - #37714
Merged
Trott merged 1 commit intoMar 13, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
aduh95
approved these changes
Mar 11, 2021
trivikr
approved these changes
Mar 12, 2021
Comment thread
doc/api/globals.md
Outdated
RaisinTen
approved these changes
Mar 12, 2021
Trott
reviewed
Mar 12, 2021
Comment thread
doc/api/globals.md
Outdated
Trott
approved these changes
Mar 12, 2021
Trott
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM with or without my nits
Sorry, something went wrong.
Trott
force-pushed
the
doc-recommend-checking-aborted-first
branch
from
4d1090e to
e49e8ca
Compare
March 13, 2021 19:24
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: nodejs#37714 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Trott
force-pushed
the
doc-recommend-checking-aborted-first
branch
from
e49e8ca to
55d4570
Compare
March 13, 2021 19:25
danielleadams
pushed a commit
that referenced
this pull request
Mar 16, 2021
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #37714 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Mar 16, 2021
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #37714 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 30, 2021
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: nodejs#37714 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: James M Snell jasnell@gmail.com