[v14.x] doc: mark modules implementation as stable - #37719
Closed
MylesBorins wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
/cc @nodejs/modules |
Sorry, something went wrong.
guybedford
approved these changes
Mar 11, 2021
aduh95
approved these changes
Mar 11, 2021
GeoffreyBooth
approved these changes
Mar 12, 2021
marsonya
approved these changes
Mar 15, 2021
BethGriggs
approved these changes
Mar 23, 2021
DerekNonGeneric
approved these changes
Mar 23, 2021
MylesBorins
force-pushed
the
v14.x-staging
branch
from
11505ad to
6b115d7
Compare
April 6, 2021 19:54
PR-URL: nodejs#35781 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
targos
force-pushed
the
modules-stable-v14.x
branch
from
ea8be7b to
e2adae0
Compare
April 24, 2021 12:54
targos
pushed a commit
that referenced
this pull request
Apr 24, 2021
PR-URL: #35781 Backport-PR-URL: #37719 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had kept the implementation as experimental to leave room for large changes that might land prior to 16. With the Semver-Major cut-off looming I don't think we'll be seeing any. Let's mark ESM stable and make it clear that folks can use this in prod
PR-URL: #35781
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: Rich Trott rtrott@gmail.com
Reviewed-By: Michaël Zasso targos@protonmail.com
Reviewed-By: Franziska Hinkelmann franziska.hinkelmann@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Myles Borins myles.borins@gmail.com
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com
Reviewed-By: Derek Lewis DerekNonGeneric@inf.is