FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v14.x] node-api: define version 8 by gabrielschulhof · Pull Request #37728 · nodejs/node · GitHub

/ node Public

[v14.x] node-api: define version 8 - #37728

Closed
gabrielschulhof wants to merge 1 commit into
nodejs:v14.x-stagingfrom
gabrielschulhof:backport-n-api-8-to-v14.x
ConversationCommits (1)ChecksFiles changed
Closed

[v14.x] node-api: define version 8#37728
gabrielschulhof wants to merge 1 commit into
nodejs:v14.x-stagingfrom
gabrielschulhof:backport-n-api-8-to-v14.x

Conversation

gabrielschulhof commented Mar 12, 2021

Copy link
Copy Markdown
Contributor

Mark as stable the APIs that define Node-API version 8.

PR-URL: #37652
Reviewed-By: @Flarna
Reviewed-By: @mhdawson
Reviewed-By: @legendecas

gabrielschulhof added the node-api Issues and PRs related to the Node-API. label Mar 12, 2021
nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v14.x labels Mar 12, 2021
gabrielschulhof added semver-minor PRs that contain new features and should be released in the next minor version. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v14.x c++ Issues and PRs that require attention from people who are familiar with C++. and removed c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v14.x labels Mar 12, 2021
mhdawson approved these changes Mar 12, 2021
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

node-api: define version 8
9b5da4f 
Mark as stable the APIs that define Node-API version 8.

PR-URL: nodejs#37652
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
targos force-pushed the backport-n-api-8-to-v14.x branch from 607198b to 9b5da4f Compare April 24, 2021 12:31

nodejs-github-bot commented Apr 24, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37653/

nodejs-github-bot commented Apr 24, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37672/

targos pushed a commit that referenced this pull request Apr 25, 2021
node-api: define version 8
36abc18 
Mark as stable the APIs that define Node-API version 8.

PR-URL: #37652
Backport-PR-URL: #37728
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

targos commented Apr 25, 2021

Copy link
Copy Markdown
Member

Landed in 36abc18

targos closed this Apr 25, 2021
targos mentioned this pull request Apr 25, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

legendecas legendecas approved these changes
Flarna Flarna approved these changes
+1 more reviewer
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL