http: fix double AbortSignal registration - #37730
Merged
Trott merged 1 commit intoMar 20, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Linkgoron
force-pushed
the
http-fix-double-abort-signal-registration
branch
from
fca3195 to
5e0e0d2
Compare
March 12, 2021 21:09
benjamingr
approved these changes
Mar 12, 2021
aduh95
reviewed
Mar 12, 2021
Comment thread
test/parallel/test-http-agent-abort-controller.js
Outdated
Linkgoron
force-pushed
the
http-fix-double-abort-signal-registration
branch
3 times, most recently
from
43d4392 to
5fae5af
Compare
March 13, 2021 01:36
Linkgoron
force-pushed
the
http-fix-double-abort-signal-registration
branch
2 times, most recently
from
fc42d56 to
38771f4
Compare
March 13, 2021 23:56
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Linkgoron
force-pushed
the
http-fix-double-abort-signal-registration
branch
from
38771f4 to
ee27a86
Compare
March 19, 2021 21:09
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Trott
approved these changes
Mar 20, 2021
Fix an issue where AbortSignals are registered twice PR-URL: nodejs#37730 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Trott
force-pushed
the
http-fix-double-abort-signal-registration
branch
from
ee27a86 to
711e210
Compare
March 20, 2021 19:53
ruyadorno
pushed a commit
that referenced
this pull request
Mar 24, 2021
Fix an issue where AbortSignals are registered twice PR-URL: #37730 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like #36431 added support for AbortSignal to net.createConnection and net.connect (will add tests/docs in a separate PR). This caused "double registration" to the AbortSignal. This PR fixes the issue by removing the signal from the internal calls to net.
Also added tests for http.agent
@benjamingr