FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: lint version numbers in doc only in the default branch by aduh95 · Pull Request #37768 · nodejs/node · GitHub

/ node Public

tools: lint version numbers in doc only in the default branch - #37768

Merged
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:skip-version-number-test
Mar 16, 2021
ConversationCommits (1)ChecksFiles changed
Merged

tools: lint version numbers in doc only in the default branch#37768
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:skip-version-number-test

Conversation

aduh95 commented Mar 16, 2021

Copy link
Copy Markdown
Contributor

Changelogs are sometimes not backported to release branches; this check
is useful on the master branch, not so much in the other branches.

Refs: #37767

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Mar 16, 2021

targos commented Mar 16, 2021

Copy link
Copy Markdown
Member

Changelogs are never backported. I'm okay with this because we usually don't need to validate REPLACEME for other targets than master, but I would still like to understand how we ended up with the issue in #37767 (comment)

aduh95 commented Mar 16, 2021

Copy link
Copy Markdown
Contributor Author

Hum that clearly doesn't work as expected, it's skipping this PR even though the PR's targeting master.

aduh95 marked this pull request as draft March 16, 2021 16:11
richardlau reviewed Mar 16, 2021
View reviewed changes
Comment thread .github/workflows/linters.yml Outdated

richardlau Mar 16, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

What does GitHub do here then if the condition fails? Does it skip the entire job, or just this step, in which case what is steps.get-released-versions.outputs.NODE_RELEASED_VERSIONS going to evaluate to in the next step?

targos Mar 16, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

it skips only this step

aduh95 Mar 16, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It skips the step where it parses the changelogs and validate the version number baed on the pattern only – see https://github.com/nodejs/node/runs/2123211599 for an example.

aduh95 marked this pull request as ready for review March 16, 2021 16:20
aduh95 force-pushed the skip-version-number-test branch from d57482c to bf391df Compare March 16, 2021 16:20
aduh95 mentioned this pull request Mar 16, 2021
Closed
aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 16, 2021

aduh95 commented Mar 16, 2021

Copy link
Copy Markdown
Contributor Author

fast-track?

danielleadams mentioned this pull request Mar 16, 2021
Merged
tools: parse changelogs only in the default branch
901ef1b 
The `lint-md` job on GitHub Actions parses the changelogs to determine
if the version numbers referenced in the YAML comments in the docs match
actual releases of Node.js.
Changelogs are sometimes not backported to release branches; this commit
disables changelog parsing on branches other than the default one.

Refs: nodejs#37767

PR-URL: nodejs#37768
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
aduh95 force-pushed the skip-version-number-test branch from bf391df to 901ef1b Compare March 16, 2021 22:04
aduh95 merged commit 901ef1b into nodejs:master Mar 16, 2021

aduh95 commented Mar 16, 2021

Copy link
Copy Markdown
Contributor Author

Landed in 901ef1b

aduh95 deleted the skip-version-number-test branch March 16, 2021 22:05
danielleadams pushed a commit that referenced this pull request Mar 17, 2021
tools: parse changelogs only in the default branch
72af5d9 
The `lint-md` job on GitHub Actions parses the changelogs to determine
if the version numbers referenced in the YAML comments in the docs match
actual releases of Node.js.
Changelogs are sometimes not backported to release branches; this commit
disables changelog parsing on branches other than the default one.

Refs: #37767

PR-URL: #37768
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

richardlau richardlau left review comments
ruyadorno ruyadorno approved these changes
+2 more reviewers
targos targos approved these changes
danielleadams danielleadams approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL