test: skip some console tests on dumb terminal - #37770
Merged
nodejs-github-bot merged 1 commit intoMay 6, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
richardlau
approved these changes
Mar 16, 2021
marsonya
approved these changes
Mar 16, 2021
cjihrig
approved these changes
Mar 17, 2021
Trott
approved these changes
Mar 20, 2021
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
approved these changes
Mar 22, 2021
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
mhdawson
approved these changes
May 5, 2022
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced May 12, 2022
This adds two more tests to be skipped on systems with only a dumb terminal. See nodejs#33165 for details.
aduh95
force-pushed
the
dumb-terminal-tests
branch
from
c1ba38a to
394a0a6
Compare
May 5, 2024 21:16
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
MoLow
approved these changes
May 6, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
May 8, 2024
This adds two more tests to be skipped on systems with only a dumb terminal. See #33165 for details. PR-URL: #37770 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 17, 2024
This adds two more tests to be skipped on systems with only a dumb terminal. See #33165 for details. PR-URL: #37770 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Merged
soophoo
pushed a commit
to soophoo/node
that referenced
this pull request
Jun 20, 2024
This adds two more tests to be skipped on systems with only a dumb terminal. See nodejs#33165 for details. PR-URL: nodejs#37770 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds two more tests to be skipped on systems with only a
dumb terminal. See PR #33165 for details.