FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v12.x] node-api: define version 8 by gabrielschulhof · Pull Request #37796 · nodejs/node · GitHub

/ node Public

[v12.x] node-api: define version 8 - #37796

Merged
richardlau merged 1 commit into
nodejs:v12.x-stagingfrom
gabrielschulhof:backport-node-api-8-to-v12.x
Mar 19, 2021
ConversationCommits (1)ChecksFiles changed
Merged

[v12.x] node-api: define version 8#37796
richardlau merged 1 commit into
nodejs:v12.x-stagingfrom
gabrielschulhof:backport-node-api-8-to-v12.x

Conversation

gabrielschulhof commented Mar 18, 2021

Copy link
Copy Markdown
Contributor

Mark as stable the APIs that define Node-API version 8.

PR-URL: #37652
Reviewed-By: @Flarna
Reviewed-By: @mhdawson
Reviewed-By: @legendecas

gabrielschulhof added c++ Issues and PRs that require attention from people who are familiar with C++. semver-minor PRs that contain new features and should be released in the next minor version. node-api Issues and PRs related to the Node-API. v12.x labels Mar 18, 2021
nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Mar 18, 2021

nodejs-github-bot commented Mar 18, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36780/

richardlau mentioned this pull request Mar 18, 2021
Merged

nodejs-github-bot commented Mar 18, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36782/

nodejs-github-bot commented Mar 18, 2021 •
edited by richardlau
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36785/ (✅)

mhdawson approved these changes Mar 18, 2021
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

nodejs-github-bot commented Mar 19, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36792/

node-api: define version 8
93dd799 
Mark as stable the APIs that define Node-API version 8.

PR-URL: nodejs#37652
Backport-PR-URL: nodejs#37796
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
richardlau force-pushed the backport-node-api-8-to-v12.x branch from 8a3773b to 93dd799 Compare March 19, 2021 12:28

richardlau commented Mar 19, 2021

Copy link
Copy Markdown
Member

Landed in 93dd799

richardlau merged commit 93dd799 into nodejs:v12.x-staging Mar 19, 2021
This was referenced Apr 18, 2023
Open
Open
137717unity mentioned this pull request Apr 18, 2023
Open
wedataintelligence mentioned this pull request Apr 18, 2023
Open
This was referenced Apr 19, 2023
Open
Open
ron-a20 mentioned this pull request Apr 19, 2023
Open
snyk-bot mentioned this pull request Apr 19, 2023
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

richardlau richardlau approved these changes
BethGriggs BethGriggs approved these changes
legendecas legendecas approved these changes
Flarna Flarna approved these changes
MylesBorins Awaiting requested review from MylesBorins
addaleax Awaiting requested review from addaleax
codebytere Awaiting requested review from codebytere
+1 more reviewer
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL