FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tty: validate file descriptor to avoid int32 overflow by aduh95 · Pull Request #37809 · nodejs/node · GitHub

/ node Public

tty: validate file descriptor to avoid int32 overflow - #37809

Merged
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:tty-isatty-int32
Mar 23, 2021
ConversationCommits (1)ChecksFiles changed
Merged

tty: validate file descriptor to avoid int32 overflow#37809
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:tty-isatty-int32

Conversation

aduh95 commented Mar 19, 2021

Copy link
Copy Markdown
Contributor

Fixes: #37805

nodejs-github-bot added needs-ci PRs that need a full CI run. tty Issues and PRs related to the tty subsystem. labels Mar 19, 2021
aduh95 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 19, 2021

nodejs-github-bot commented Mar 19, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36810/

nodejs-github-bot commented Mar 19, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36821/

nodejs-github-bot commented Mar 20, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36863/

nodejs-github-bot commented Mar 20, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36873/

tty: validate file descriptor to avoid int32 overflow
134fb5a 
Fixes: nodejs#37805

PR-URL: nodejs#37809
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
aduh95 force-pushed the tty-isatty-int32 branch from 544bd16 to 134fb5a Compare March 23, 2021 10:02

aduh95 commented Mar 23, 2021

Copy link
Copy Markdown
Contributor Author

Landed in 134fb5a

aduh95 merged commit 134fb5a into nodejs:master Mar 23, 2021
aduh95 deleted the tty-isatty-int32 branch March 23, 2021 10:03
ruyadorno pushed a commit that referenced this pull request Mar 24, 2021
tty: validate file descriptor to avoid int32 overflow
3452618 
Fixes: #37805

PR-URL: #37809
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
ruyadorno mentioned this pull request Mar 30, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
tty: validate file descriptor to avoid int32 overflow
d89d55a 
Fixes: #37805

PR-URL: #37809
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams mentioned this pull request May 3, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
BridgeAR BridgeAR approved these changes
RaisinTen RaisinTen approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. tty Issues and PRs related to the tty subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"tty.isatty" results in an abort

6 participants

Back | FazBrowse Home | New Git URL