FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

http: use CRLF conistently in _http_outgoing.js by danbev · Pull Request #37851 · nodejs/node · GitHub

/ node Public

http: use CRLF conistently in _http_outgoing.js - #37851

Closed
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:http_outgoing_crlf
ConversationCommits (1)ChecksFiles changed
Closed

http: use CRLF conistently in _http_outgoing.js#37851
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:http_outgoing_crlf

Conversation

danbev commented Mar 21, 2021

Copy link
Copy Markdown
Contributor

No description provided.

nodejs-github-bot added http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. labels Mar 21, 2021

This comment has been minimized.

Sign in to view

nodejs-github-bot commented Mar 22, 2021 •
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36893/ 💚

jasnell commented Mar 22, 2021

Copy link
Copy Markdown
Member

There doesn't appear to be a reason to make this one wait. Fast track? Please 👍🏻

jasnell added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. and removed needs-ci PRs that need a full CI run. labels Mar 22, 2021

jasnell commented Mar 22, 2021

Copy link
Copy Markdown
Member

Landed in f4d3d12

jasnell closed this Mar 22, 2021
jasnell pushed a commit that referenced this pull request Mar 22, 2021
http: use CRLF conistently in _http_outgoing.js
f4d3d12 
PR-URL: #37851
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danbev deleted the http_outgoing_crlf branch March 23, 2021 05:09

ruyadorno commented Mar 29, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

This doesn't land cleanly on v15.x-staging, needs to be backported.

BethGriggs mentioned this pull request Apr 12, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
himself65 himself65 approved these changes
RaisinTen RaisinTen approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. http Issues or PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL