src: document newer values for --unhandled-rejections flag - #37899
Merged
aduh95 merged 1 commit intoMar 28, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
aduh95
reviewed
Mar 25, 2021
Comment thread
src/node_options.cc
Outdated
addaleax
approved these changes
Mar 25, 2021
Copy link
Copy Markdown
Contributor
Author
|
I can make that change though for consistency with the rest of the options it would be better as (default: throw). (Also the default is throw not unhandledRejection.) |
Sorry, something went wrong.
glasser
force-pushed
the
unhandled-rejections-help
branch
from
b189d4d to
ef5f429
Compare
March 25, 2021 14:16
Copy link
Copy Markdown
Contributor
Author
|
Updated to put the default at the end. It uses a similar styling to other entries, though I don't see other entries that have another parenthesized thing right before the (default:; I put a period in between which seems a bit better. |
Sorry, something went wrong.
aduh95
approved these changes
Mar 25, 2021
Copy link
Copy Markdown
Contributor
Author
|
By the way, I noticed that the indentation of wrapped help text looks strange and have filed #37911 to resolve. |
Sorry, something went wrong.
RaisinTen
approved these changes
Mar 26, 2021
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
approved these changes
Mar 27, 2021
These values were added in v15.0.0 by nodejs#33475 but were not included in the `node --help` output. Also documents which value is the default. PR-URL: nodejs#37899 Fixes: nodejs#37896 Refs: nodejs#33475 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
force-pushed
the
unhandled-rejections-help
branch
from
ef5f429 to
ce6d756
Compare
March 28, 2021 17:26
ruyadorno
pushed a commit
that referenced
this pull request
Mar 29, 2021
These values were added in v15.0.0 by #33475 but were not included in the `node --help` output. Also documents which value is the default. PR-URL: #37899 Fixes: #37896 Refs: #33475 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
ruyadorno
pushed a commit
that referenced
this pull request
Mar 30, 2021
These values were added in v15.0.0 by #33475 but were not included in the `node --help` output. Also documents which value is the default. PR-URL: #37899 Fixes: #37896 Refs: #33475 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
May 1, 2021
These values were added in v15.0.0 by #33475 but were not included in the `node --help` output. Also documents which value is the default. PR-URL: #37899 Fixes: #37896 Refs: #33475 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These values were added in v15.0.0 by #33475 but were not included in the
node --help output.
Also document which value is the default.
Fixes: #37896