FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v14.x] deps: update to cjs-module-lexer@1.1.1 by guybedford · Pull Request #38002 · nodejs/node · GitHub

/ node Public

[v14.x] deps: update to cjs-module-lexer@1.1.1 - #38002

Closed
guybedford wants to merge 1 commit into
nodejs:v14.x-stagingfrom
guybedford:cjs-module-lexer-update-14
ConversationCommits (1)ChecksFiles changed
Closed

[v14.x] deps: update to cjs-module-lexer@1.1.1#38002
guybedford wants to merge 1 commit into
nodejs:v14.x-stagingfrom
guybedford:cjs-module-lexer-update-14

Conversation

guybedford commented Mar 31, 2021

Copy link
Copy Markdown
Contributor

This backports the cjs-module-lexer update from #37992 for 14.x.

Note this branch didn't get the 1.1.0 update yet, so this handles the full upgrade path.

@nodejs/modules

nodejs-github-bot added needs-ci PRs that need a full CI run. v14.x labels Mar 31, 2021

nodejs-github-bot commented Mar 31, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37071/

guybedford force-pushed the cjs-module-lexer-update-14 branch from 884fc07 to efcad79 Compare April 8, 2021 14:34

nodejs-github-bot commented Apr 8, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37300/

MylesBorins approved these changes Apr 8, 2021
View reviewed changes

MylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

RSLGTM

guybedford changed the base branch from v14.x-staging to v14.x April 8, 2021 22:48
guybedford changed the base branch from v14.x to v14.x-staging April 8, 2021 22:53
guybedford added a commit that referenced this pull request Apr 14, 2021
deps: update to cjs-module-lexer@1.1.1
d56079a 
PR-URL: #38002
Backport-PR-URL: #37992
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

guybedford commented Apr 14, 2021

Copy link
Copy Markdown
Contributor Author

Landed in d56079a.

guybedford closed this Apr 14, 2021
This was referenced Apr 27, 2021
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hybrist hybrist approved these changes
+1 more reviewer
MylesBorins MylesBorins approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL