| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
There was a problem hiding this comment.
Thanks for making the PR. :)
Could you please address this review comment from a previous PR attempt to fix the related issue: #36458 (comment)?
I'm not sure this warrants its own section. Seems like it should go in the section of whatever call might result in requiring the unref() call. It would be good to incorporate it into an existing section, I think.
nit: I think the commit message should say Fixes instead of Ref (but that can be fixed while landing).
Sorry, something went wrong.
|
@RaisinTen - Thanks for the review!
I did incorporate the edits into an existing section instead of making a new section i.e. readline.createInterface(options) section. Am I missing something else? |
Sorry, something went wrong.
|
The wait on the readable stream can also be ended by these calls: readable.destroy();
readable.pause();
readable.unshift(null);Should we also document these here? |
Sorry, something went wrong.
|
@RaisinTen Sure, we could do it in both places (readable and readline). Do you think it makes sense to add the following in the readable section? I can make that change
|
Sorry, something went wrong.
FWIW I don't think it's necessary: I think it's irrelevant to a user trying to interface with stdin that there are several ways to "make the program not hang". We don't have to be thorough on how the stream API work in the readline API documentation. |
Sorry, something went wrong.
PR-URL: nodejs#38019 Fixes: nodejs#36154 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
| Back | FazBrowse Home | New Git URL |
Fixes: #36154