FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add parentheses to function and move reference by Trott · Pull Request #38066 · nodejs/node · GitHub

/ node Public

doc: add parentheses to function and move reference - #38066

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:parens
Closed

doc: add parentheses to function and move reference#38066
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:parens

Conversation

Trott commented Apr 4, 2021

Copy link
Copy Markdown
Member

Add parentheses as unref() is a function. Move it to the correct
lexically-sorted location in the reference list.

nodejs-github-bot added doc Issues and PRs related to the documentations. readline Issues and PRs related to the built-in readline module. labels Apr 4, 2021
RaisinTen added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 4, 2021
Add parentheses as `unref()` is a function. Move it to the correct
lexically-sorted location in the reference list.

PR-URL: nodejs#38066
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Trott commented Apr 6, 2021

Copy link
Copy Markdown
Member Author

Landed in ab42ef3

Trott closed this Apr 6, 2021
Trott deleted the parens branch April 6, 2021 00:31
targos pushed a commit that referenced this pull request May 1, 2021
Add parentheses as `unref()` is a function. Move it to the correct
lexically-sorted location in the reference list.

PR-URL: #38066
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams mentioned this pull request May 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. readline Issues and PRs related to the built-in readline module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL