test: correct test comment - #38095
Closed
evanlucas wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This corrects a comment on the signal type used in the test.
benjamingr
approved these changes
Apr 5, 2021
Copy link
Copy Markdown
Member
|
Hi @evanlucas 👋 hope life is going great :) |
Sorry, something went wrong.
lpinca
approved these changes
Apr 5, 2021
cjihrig
approved these changes
Apr 6, 2021
jasnell
approved these changes
Apr 6, 2021
Copy link
Copy Markdown
Member
|
There's no reason to make this one wait the 48 hours to land. Please 👍🏻 to fast-track |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
evanlucas
added a commit
that referenced
this pull request
Apr 6, 2021
This corrects a comment on the signal type used in the test. PR-URL: #38095 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Copy link
Copy Markdown
Member
|
Sorry about the tag after landing. It was a Pull request filter/search mixup. |
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
May 1, 2021
This corrects a comment on the signal type used in the test. PR-URL: #38095 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This corrects a comment on the signal type used in the test.