FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

crypto: fixup randomFill size and offset handling by jasnell · Pull Request #38138 · nodejs/node · GitHub

/ node Public

crypto: fixup randomFill size and offset handling - #38138

Closed
jasnell wants to merge 3 commits into
nodejs:masterfrom
jasnell:fixup-randomfill-size
ConversationCommits (3)ChecksFiles changed
Closed

crypto: fixup randomFill size and offset handling#38138
jasnell wants to merge 3 commits into
nodejs:masterfrom
jasnell:fixup-randomfill-size

Conversation

jasnell commented Apr 7, 2021

Copy link
Copy Markdown
Member

Fixes: #38137

Signed-off-by: James M Snell jasnell@gmail.com

nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Apr 7, 2021
jasnell mentioned this pull request Apr 7, 2021
Closed

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view
crypto: fixup randomFill size and offset handling
b394ef2 
Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell force-pushed the fixup-randomfill-size branch from 023bb27 to b394ef2 Compare April 7, 2021 18:31

nodejs-github-bot commented Apr 7, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37258/

addaleax reviewed Apr 7, 2021
View reviewed changes

addaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I guess this LGTM in the sense that it makes the code work correctly now, but I’m not really eager to click “approve” given how hard to understand this code is (Functions whose names start with assert that silently use different units for input and output? I think we can do better…)

jasnell commented Apr 7, 2021

Copy link
Copy Markdown
Member Author

that silently use different units for input and output? I think we can do better…)

Agreed. I left these as is during the refactor and didn't like the way these were implemented then and still don't. It'll be good to refactor these next but let's address the immediate bug first.

addaleax approved these changes Apr 8, 2021
View reviewed changes

addaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Let’s at least leave a comment about why this is so confusing

Comment thread lib/internal/crypto/random.js
arkerone mentioned this pull request Apr 8, 2021
Closed
[Squash] nit
1e91615 
Co-authored-by: Anna Henningsen <anna@addaleax.net>
jasnell added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 8, 2021

nodejs-github-bot commented Apr 8, 2021 •
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37298/ 💚

RaisinTen reviewed Apr 8, 2021
View reviewed changes
Comment thread lib/internal/crypto/random.js Outdated
[Squash] nit
4643682 
Co-authored-by: Darshan Sen <raisinten@gmail.com>
jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 8, 2021

jasnell commented Apr 8, 2021

Copy link
Copy Markdown
Member Author

CI is green on this and it fixes a bug. There's no reason to make it wait the full 48 hours. Please 👍🏻 to fast track

nodejs-github-bot commented Apr 9, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37331/

jasnell added a commit that referenced this pull request Apr 9, 2021
crypto: fixup randomFill size and offset handling
d2f116c 
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #38138
Fixes: #38137
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

jasnell commented Apr 9, 2021

Copy link
Copy Markdown
Member Author

Landed in d2f116c

jasnell closed this Apr 9, 2021
BethGriggs mentioned this pull request Apr 12, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
tniessen tniessen approved these changes
addaleax addaleax approved these changes
lpinca lpinca approved these changes
RaisinTen RaisinTen approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. crypto Issues and PRs related to the crypto subsystem. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

crypto.randomFill : error with TypedArray

8 participants

Back | FazBrowse Home | New Git URL