doc: add link to V8 - #38144
Closed
VoltrexKeyva wants to merge 3 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Added the link redirecting to the V8 engine github repository just like libuv.
V8 should be above Worker.
gengjiawen
approved these changes
Apr 8, 2021
jasnell
approved these changes
Apr 8, 2021
RaisinTen
approved these changes
Apr 8, 2021
richardlau
reviewed
Apr 8, 2021
Comment thread
doc/api/addons.md
Outdated
V8 redirect URL should redirect to the google source original domain instead of the mirror.
richardlau
approved these changes
Apr 8, 2021
addaleax
approved these changes
Apr 8, 2021
cjihrig
approved these changes
Apr 9, 2021
marsonya
approved these changes
Apr 9, 2021
RaisinTen
pushed a commit
that referenced
this pull request
Apr 10, 2021
Added the link redirecting to the V8 engine github repository just like libuv. PR-URL: #38144 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Added the link redirecting to the V8 engine github repository just like libuv. PR-URL: #38144 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
May 8, 2021
Added the link redirecting to the V8 engine github repository just like libuv. PR-URL: #38144 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the link redirecting to the V8 engine main domain just like libuv.