deps: update llhttp to 5.1.0 - #38146
Closed
indutny wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
indutny
force-pushed
the
feature/llhttp-5.0
branch
from
46b44a3 to
84c9f0c
Compare
April 8, 2021 05:30
indutny
force-pushed
the
feature/llhttp-5.0
branch
from
84c9f0c to
24fd191
Compare
April 8, 2021 05:38
mcollina
approved these changes
Apr 8, 2021
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Should this be backported?
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
ronag
approved these changes
Apr 8, 2021
dnlup
approved these changes
Apr 8, 2021
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@mcollina possibly, but I the PRI * ... handling changes the behavior a bit so I'm wary of breaking existing code. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I've added a bunch of don't land labels to match this. |
Sorry, something went wrong.
gengjiawen
approved these changes
Apr 9, 2021
indutny
added a commit
that referenced
this pull request
Apr 10, 2021
PR-URL: #38146 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Daniele Belardi <dwon.dnl@gmail.com>
Copy link
Copy Markdown
Member
|
It looks like this has broken the tests for body-parser and express: #37678 (comment) |
Sorry, something went wrong.
denihs
pushed a commit
to meteor/node-v14-esm
that referenced
this pull request
Jun 28, 2023
PR-URL: nodejs#38146 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Daniele Belardi <dwon.dnl@gmail.com> # Conflicts: # deps/llhttp/README.md # deps/llhttp/include/llhttp.h # deps/llhttp/src/llhttp.c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @nodejs/http @nodejs/http2 Note that handling of h2 preamble has changed and llhttp now returns HPE_PAUSED_H2_UPGRADE error.