FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: check the different error code on IBM i by dmabupt · Pull Request #38159 · nodejs/node · GitHub

/ node Public

test: check the different error code on IBM i - #38159

Closed
dmabupt wants to merge 1 commit into
nodejs:masterfrom
dmabupt:ibmi_test_fs_read_type
ConversationCommits (1)ChecksFiles changed
Closed

test: check the different error code on IBM i#38159
dmabupt wants to merge 1 commit into
nodejs:masterfrom
dmabupt:ibmi_test_fs_read_type

Conversation

dmabupt commented Apr 9, 2021

Copy link
Copy Markdown
Contributor

Fixes: #36925

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 9, 2021
dmabupt added the ibm i Issues and PRs related to the IBM i platform. label Apr 9, 2021
cjihrig approved these changes Apr 9, 2021
View reviewed changes
Comment thread test/parallel/test-fs-read-type.js
if (err) {
assert.strictEqual(err.code, 'EFBIG');
if (common.isIBMi)
assert.strictEqual(err.errno, -127);

cjihrig Apr 9, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

What error does 127 map to on IBM i? Should we try to map it in libuv?

dmabupt Apr 9, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It is EOVERFLOW

$ grep 127 /usr/include/errno.h 
#define EOVERFLOW       127     /* value too large to be stored in data type */

RaisinTen Apr 9, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

What error does 127 map to on IBM i? Should we try to map it in libuv?

@cjihrig PR to add a mapping for EOVERFLOW: libuv/libuv#3145

dmabupt commented Apr 9, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-commit-ibmi/329/
Test fs_read_type passed - https://ci.nodejs.org/job/node-test-commit-ibmi/329/nodes=ibmi72-ppc64/testReport/(root)/test/parallel_test_fs_read_type/

nodejs-github-bot commented Apr 9, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37323/

nodejs-github-bot commented Apr 9, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37328/

RaisinTen added a commit to RaisinTen/libuv that referenced this pull request Apr 9, 2021
include: add EOVERFLOW status code mapping
3774ea5 
Refs: nodejs/node#38159 (comment)
RaisinTen mentioned this pull request Apr 9, 2021
Merged

nodejs-github-bot commented Apr 9, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37332/

RaisinTen added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 9, 2021
dmabupt added a commit that referenced this pull request Apr 12, 2021
test: check the different error code on IBM i
db9cf52 
Fixes: #36925

PR-URL: #38159
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>

dmabupt commented Apr 12, 2021

Copy link
Copy Markdown
Contributor Author

landed in db9cf52

dmabupt closed this Apr 12, 2021
dmabupt deleted the ibmi_test_fs_read_type branch April 12, 2021 02:49
BethGriggs mentioned this pull request Apr 12, 2021
Merged
vtjnash pushed a commit to libuv/libuv that referenced this pull request May 13, 2021
include: add EOVERFLOW status code mapping
9739400 
Refs: nodejs/node#38159 (comment)
PR-URL: #3145
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jameson Nash <vtjnash@gmail.com>
RaisinTen mentioned this pull request May 13, 2021
Closed
RaisinTen added a commit to RaisinTen/node that referenced this pull request Aug 22, 2021
test: use error code mapping in place of raw errno
7c8156d 
Refs: nodejs#38159 (comment)
jasnell pushed a commit that referenced this pull request Aug 28, 2021
test: use error code mapping in place of raw errno
21cf618 
Refs: #38159 (comment)

PR-URL: #38675
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Sep 6, 2021
test: use error code mapping in place of raw errno
007e285 
Refs: #38159 (comment)

PR-URL: #38675
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
JeffroMF pushed a commit to JeffroMF/libuv that referenced this pull request May 16, 2022
include: add EOVERFLOW status code mapping
74a85a5 
Refs: nodejs/node#38159 (comment)
PR-URL: libuv#3145
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jameson Nash <vtjnash@gmail.com>
liujinye-sys pushed a commit to open-vela/apps_system_libuv that referenced this pull request Jul 23, 2025
include: add EOVERFLOW status code mapping
6c4125f 
Refs: nodejs/node#38159 (comment)
PR-URL: libuv/libuv#3145
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jameson Nash <vtjnash@gmail.com>
liujinye-sys pushed a commit to open-vela/apps_system_libuv that referenced this pull request Dec 16, 2025
include: add EOVERFLOW status code mapping
38dc2a7 
Refs: nodejs/node#38159 (comment)
PR-URL: libuv/libuv#3145
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jameson Nash <vtjnash@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

RaisinTen RaisinTen approved these changes
cjihrig cjihrig approved these changes
richardlau richardlau approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. ibm i Issues and PRs related to the IBM i platform. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test-fs-read-type fails on IBM i

6 participants

Back | FazBrowse Home | New Git URL