FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix typo in cli.md by arkerone · Pull Request #38163 · nodejs/node · GitHub

/ node Public

doc: fix typo in cli.md - #38163

Closed
arkerone wants to merge 2 commits into
nodejs:masterfrom
arkerone:doc/fix-typo-cli
Closed

doc: fix typo in cli.md#38163
arkerone wants to merge 2 commits into
nodejs:masterfrom
arkerone:doc/fix-typo-cli

Conversation

arkerone commented Apr 9, 2021

Copy link
Copy Markdown
Contributor

I found two typos in cli documentation :

strack -> stack
modifiying -> modifying

nodejs-github-bot added cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. labels Apr 9, 2021
richardlau added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 9, 2021

juanarbol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Amazing!

antsmartian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Fast track?

RaisinTen added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 10, 2021

jasnell commented Apr 10, 2021

Copy link
Copy Markdown
Member

Landed in 5ba5cc8

jasnell closed this Apr 10, 2021
jasnell pushed a commit that referenced this pull request Apr 10, 2021
PR-URL: #38163
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
arkerone deleted the doc/fix-typo-cli branch April 21, 2021 08:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.


Back | FazBrowse Home | New Git URL