bootstrap: mksnapshot should show JS error summaries - #38174
Closed
bmeck wants to merge 6 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
bmeck
force-pushed
the
mksnapshot-show-js-error
branch
from
8f5e7f7 to
2ffc11a
Compare
April 9, 2021 20:36
addaleax
approved these changes
Apr 9, 2021
This comment has been minimized.
jasnell
approved these changes
Apr 9, 2021
targos
reviewed
Apr 10, 2021
Comment thread
tools/snapshot/snapshot_builder.cc
Outdated
Comment thread
tools/snapshot/snapshot_builder.cc
Outdated
Co-authored-by: Michaël Zasso <targos@protonmail.com>
Co-authored-by: Michaël Zasso <targos@protonmail.com>
This comment has been minimized.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
CI is green except a timeout |
Sorry, something went wrong.
bmeck
added a commit
that referenced
this pull request
Apr 13, 2021
PR-URL: #38174 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Copy link
Copy Markdown
Member
Author
|
Landed in 837f7e2f71ce |
Sorry, something went wrong.
BethGriggs
pushed a commit
that referenced
this pull request
Apr 15, 2021
PR-URL: #38174 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Copy link
Copy Markdown
Member
|
Sorry for missing the ping: just FYI SetIsolateErrorHandlers() can install error handlers that print uncaught exceptions and it's used by the ordinary Node.js instances - I don't quite remember why it wasn't used by mksnapshot, though. Also there are some routines in node_errors.cc that can be reused to print these errors. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came up while trying to debug some stuff going on in the snapshot, makes debugging a lot easier. IDK if we want to do something other than use abort() here.