FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: clarify child_process close event by Linkgoron · Pull Request #38181 · nodejs/node · GitHub

/ node Public

doc: clarify child_process close event - #38181

Closed
Linkgoron wants to merge 2 commits into
nodejs:masterfrom
Linkgoron:docs-cp-close-after-exit
ConversationCommits (2)ChecksFiles changed
Closed

doc: clarify child_process close event#38181
Linkgoron wants to merge 2 commits into
nodejs:masterfrom
Linkgoron:docs-cp-close-after-exit

Conversation

Linkgoron commented Apr 10, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Clarify the 'close' event description in the child_process docs.

This event is a bit confusing, as the documentation did not state that:

  • It's supposed to get emitted after "exit" was already emitted.
  • It also emits when the child_process has failed to spawn (and thus, exit will never be emitted). Another detail, that I did not add to the docs, is that in this case the exit code passed to the closed handler is negative. Should this be mentioned?

fixes: #37998

doc: clarify child_process close event
23569e6 
clarify the 'close' event description in the child_process docs.

fixes: nodejs#37998
nodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. labels Apr 10, 2021
benjamingr approved these changes Apr 10, 2021
View reviewed changes

benjamingr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Linkgoron added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 10, 2021

jasnell commented Apr 12, 2021

Copy link
Copy Markdown
Member

Landed in 474fbb5

jasnell closed this Apr 12, 2021
jasnell pushed a commit that referenced this pull request Apr 12, 2021
doc: clarify child_process close event
474fbb5 
clarify the 'close' event description in the child_process docs.

fixes: #37998

PR-URL: #38181
Fixes: #37998
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 15, 2021
doc: clarify child_process close event
7997ae1 
clarify the 'close' event description in the child_process docs.

fixes: #37998

PR-URL: #38181
Fixes: #37998
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs mentioned this pull request Apr 16, 2021
Merged
pgfisico mentioned this pull request Apr 27, 2021
Closed
targos pushed a commit that referenced this pull request May 1, 2021
doc: clarify child_process close event
bb8db84 
clarify the 'close' event description in the child_process docs.

fixes: #37998

PR-URL: #38181
Fixes: #37998
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams mentioned this pull request May 3, 2021
Merged
danielleadams pushed a commit that referenced this pull request May 8, 2021
doc: clarify child_process close event
22d39d3 
clarify the 'close' event description in the child_process docs.

fixes: #37998

PR-URL: #38181
Fixes: #37998
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
coderabbitai Bot mentioned this pull request Aug 12, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
benjamingr benjamingr approved these changes
lpinca lpinca approved these changes
marsonya marsonya approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

child_process 'close' always (?) emitted after 'exit'

6 participants

Back | FazBrowse Home | New Git URL