fs: validate encoding to binding.writeString() - #38183
Merged
cjihrig merged 1 commit intoApr 12, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
BridgeAR
approved these changes
Apr 10, 2021
aduh95
approved these changes
Apr 10, 2021
RaisinTen
approved these changes
Apr 10, 2021
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
antsmartian
approved these changes
Apr 10, 2021
Copy link
Copy Markdown
Member
|
nit: Refs -> Fixes in the commit message |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
The binding layer performs some validation of the encoding and data passed to WriteString(). This commit adds similar validation to the JS layer for better error handling. PR-URL: nodejs#38183 Fixes: nodejs#38168 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The binding layer performs some validation of the encoding and data passed to WriteString(). This commit adds similar validation to the JS layer for better error handling.
Fixes: #38168 (I believe this issue was closed prematurely)