lib/path: Add JSDoc Types - #38186
Closed
Skn0tt wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
I hope this PR and #38185 are of help. Let me know if I need to change anything :) |
Sorry, something went wrong.
Ayase-252
reviewed
Apr 10, 2021
Ayase-252
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks for contribution!
Sorry, something went wrong.
Comment thread
lib/path.js
Outdated
Comment thread
lib/path.js
Outdated
Comment thread
lib/path.js
Outdated
Comment thread
lib/path.js
Outdated
Comment thread
lib/path.js
Outdated
Comment thread
lib/path.js
Outdated
Comment thread
lib/path.js
Outdated
Comment thread
lib/path.js
Outdated
Comment thread
lib/path.js
Outdated
Ayase-252
reviewed
Apr 10, 2021
Comment thread
lib/path.js
Outdated
Copy link
Copy Markdown
Member
|
Hi, @Skn0tt It seems there are still some errors from linters, would you mind fix them? /home/runner/work/node/node/lib/path.js Error: 1276:26 error Trailing spaces not allowed no-trailing-spaces Error: 1306:26 error Trailing spaces not allowed no-trailing-spaces Error: 1307:25 error Trailing spaces not allowed no-trailing-spaces Error: 1386:26 error Trailing spaces not allowed no-trailing-spaces Error: 1444:26 error Trailing spaces not allowed no-trailing-spaces Error: 1445:1 error This line has a length of 86. Maximum allowed is 80 max-len You can also run linters locally to detect linting problem by make lint or vcbuild lint based on your platform. Please refer to Running Tests section. |
Sorry, something went wrong.
Comment thread
lib/path.js
Outdated
Comment thread
lib/path.js
Outdated
Comment thread
lib/path.js
Outdated
Comment thread
lib/path.js
Outdated
Comment thread
lib/path.js
Outdated
Comment thread
lib/path.js
Outdated
Comment thread
lib/path.js
Outdated
Comment thread
lib/path.js
Outdated
bmeck
approved these changes
Apr 12, 2021
bmeck
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
targos
reviewed
Apr 13, 2021
Comment thread
lib/path.js
Outdated
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
targos
approved these changes
Apr 14, 2021
targos
force-pushed
the
path-jsdoc-types
branch
from
161c036 to
7adcd94
Compare
April 14, 2021 15:06
targos
pushed a commit
that referenced
this pull request
Apr 14, 2021
PR-URL: #38186 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Copy link
Copy Markdown
Member
|
Landed in f1a21e5. Thanks for the contribution! |
Sorry, something went wrong.
BethGriggs
pushed a commit
that referenced
this pull request
Apr 15, 2021
PR-URL: #38186 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
PR-URL: #38186 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
May 8, 2021
PR-URL: #38186 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by @bmeck: https://twitter.com/bradleymeck/status/1380643627211354115
Changes based on https://nodejs.org/dist/latest-v14.x/docs/api/path.html#path_path_delimiter.