lib: add globalThis to primordials - #38211
Merged
aduh95 merged 1 commit intoApr 13, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
bmeck
approved these changes
Apr 12, 2021
This comment has been minimized.
marsonya
approved these changes
Apr 12, 2021
jasnell
approved these changes
Apr 12, 2021
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
CI is green and seems uncontroversial. There's no reason for this to wait the full 48 hours. Please 👍🏻 to fast-track |
Sorry, something went wrong.
PR-URL: nodejs#38211 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
force-pushed
the
globalThis-primordials
branch
from
864ed83 to
9d46c81
Compare
April 13, 2021 16:34
aduh95
force-pushed
the
globalThis-primordials
branch
from
9d46c81 to
23d2c54
Compare
April 13, 2021 16:34
This was referenced Apr 14, 2021
aduh95
added a commit
to aduh95/node
that referenced
this pull request
Jul 19, 2021
PR-URL: nodejs#38211 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful to avoid throwing exception if globalThis is being overwritten in userland:
I'm using no-restricted-globals instead of node-core/prefer-primordials to generate better error messages.
lib/internal/process/execution.js 58:22 error Use `const { globalThisModule } = primordials;` instead of the global node-core/prefer-primordials 75:3 error Use `const { globalThis__filename } = primordials;` instead of the global node-core/prefer-primordials 92:5 error Use `const { globalThisModule } = primordials;` instead of the global node-core/prefer-primordialslib/internal/process/execution.js 58:22 error Unexpected use of 'globalThis'. Use `const { globalThis } = primordials;` instead of the global no-restricted-globals 75:3 error Unexpected use of 'globalThis'. Use `const { globalThis } = primordials;` instead of the global no-restricted-globals 92:5 error Unexpected use of 'globalThis'. Use `const { globalThis } = primordials;` instead of the global no-restricted-globals