FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: Update BUILDING.md for Apple Silicon by AshCripps · Pull Request #38227 · nodejs/node · GitHub

/ node Public

doc: Update BUILDING.md for Apple Silicon - #38227

Closed
AshCripps wants to merge 1 commit into
nodejs:masterfrom
AshCripps:update-building-md
Closed

doc: Update BUILDING.md for Apple Silicon#38227
AshCripps wants to merge 1 commit into
nodejs:masterfrom
AshCripps:update-building-md

Conversation

Copy link
Copy Markdown
Member

Update BUILDING.md to be correct for Apple Silicon for 16.x

nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Apr 13, 2021
aduh95 added arm Issues and PRs related to the ARM architecture. macos Issues and PRs related to the macOS platform / OSX. labels Apr 13, 2021

aduh95 commented Apr 13, 2021

Copy link
Copy Markdown
Contributor

Does this need to be backported to v14.x and v15.x?

AshCripps commented Apr 13, 2021
edited
Loading

Copy link
Copy Markdown
Member Author

Does this need to be backported to v14.x and v15.x?

No we dont release for Apple silicon on those lines

BethGriggs added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 13, 2021

Copy link
Copy Markdown
Member

Fast-track?

Comment thread BUILDING.md Outdated
AshCripps force-pushed the update-building-md branch from f12e260 to 5b74f10 Compare April 14, 2021 13:41
AshCripps pushed a commit that referenced this pull request Apr 14, 2021
PR-URL: #38227
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

Copy link
Copy Markdown
Member Author

Landed in 98c2067

AshCripps closed this Apr 14, 2021
AshCripps deleted the update-building-md branch April 15, 2021 10:21
BethGriggs pushed a commit that referenced this pull request Apr 15, 2021
PR-URL: #38227
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arm Issues and PRs related to the ARM architecture. build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. macos Issues and PRs related to the macOS platform / OSX.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants


Back | FazBrowse Home | New Git URL