FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix typo in buffer.md by arkerone · Pull Request #38243 · nodejs/node · GitHub

/ node Public

doc: fix typo in buffer.md - #38243

Merged
aduh95 merged 1 commit into
nodejs:masterfrom
arkerone:doc/fix-typo-buffer
Apr 17, 2021
Merged

doc: fix typo in buffer.md#38243
aduh95 merged 1 commit into
nodejs:masterfrom
arkerone:doc/fix-typo-buffer

Conversation

Copy link
Copy Markdown
Contributor

I found a typo in buffer documentation :

alterered -> altered

nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. labels Apr 15, 2021

jasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Fast-track? Please 👍🏻

jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 15, 2021

jasnell commented Apr 15, 2021

Copy link
Copy Markdown
Member

Unrelated github CI failure. Will land once we get a good run.

marsonya added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 16, 2021
"alterered" ->  "altered"

PR-URL: nodejs#38243
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
aduh95 force-pushed the doc/fix-typo-buffer branch from faf4e36 to fb93b71 Compare April 17, 2021 13:35

aduh95 commented Apr 17, 2021

Copy link
Copy Markdown
Contributor

Landed in fb93b71

aduh95 merged commit fb93b71 into nodejs:master Apr 17, 2021
arkerone deleted the doc/fix-typo-buffer branch April 21, 2021 08:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.


Back | FazBrowse Home | New Git URL