FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: fix finalization crash by jasnell · Pull Request #38250 · nodejs/node · GitHub

/ node Public

src: fix finalization crash - #38250

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:try-fixing-finalization-crash
ConversationCommits (1)ChecksFiles changed
Closed

src: fix finalization crash#38250
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:try-fixing-finalization-crash

Conversation

jasnell commented Apr 15, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes: #38040

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Apr 15, 2021

nodejs-github-bot commented Apr 15, 2021 •
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37498/ 💚

jasnell mentioned this pull request Apr 15, 2021
Closed
jasnell added fast-track PRs that do not need to wait for 48 hours to land. and removed needs-ci PRs that need a full CI run. labels Apr 15, 2021

jasnell commented Apr 15, 2021

Copy link
Copy Markdown
Member Author

If this does fix #38040 and CI is good, would be good to fast-track. Please 👍🏻

jasnell changed the title src: maybe fix finalization crash src: fix finalization crash Apr 15, 2021
jasnell added a commit that referenced this pull request Apr 15, 2021
src: fix finalization crash
fc20e83 
PR-URL: #38250
Fixes: #38040
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

jasnell commented Apr 15, 2021

Copy link
Copy Markdown
Member Author

Landed in fc20e83

jasnell closed this Apr 15, 2021
BethGriggs mentioned this pull request Apr 16, 2021
Merged
legendecas added the node-api Issues and PRs related to the Node-API. label Apr 16, 2021

legendecas commented Apr 16, 2021

Copy link
Copy Markdown
Member

@jasnell 👍 for quick fixing on the issue. Unfortunately, this patch doesn't ultimately fix the use-after-free issue on node-api finalization. #38000 is still required to fix the use-after-free on v8impl::Reference.

legendecas mentioned this pull request Apr 21, 2021
Closed
targos pushed a commit that referenced this pull request May 1, 2021
src: fix finalization crash
ec4be2d 
PR-URL: #38250
Fixes: #38040
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams mentioned this pull request May 3, 2021
Merged
danielleadams pushed a commit that referenced this pull request May 8, 2021
src: fix finalization crash
27ebcb7 
PR-URL: #38250
Fixes: #38040
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
legendecas mentioned this pull request Mar 29, 2022
Closed
legendecas pushed a commit to legendecas/node that referenced this pull request Mar 29, 2022
src: fix finalization crash
2a8bdd1 
PR-URL: nodejs#38250
Fixes: nodejs#38040
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
richardlau pushed a commit that referenced this pull request Mar 30, 2022
src: fix finalization crash
e707514 
PR-URL: #38250
Backport-PR-URL: #42512
Fixes: #38040
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
richardlau mentioned this pull request Mar 30, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

BethGriggs BethGriggs approved these changes
aduh95 aduh95 approved these changes
targos Awaiting requested review from targos
richardlau Awaiting requested review from richardlau

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. node-api Issues and PRs related to the Node-API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

local fatal error for test/js-native-api/test_object/test.js

5 participants

Back | FazBrowse Home | New Git URL