typings: add JSDoc typings for readline - #38253
Closed
VoltrexKeyva wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
jasnell
approved these changes
Apr 16, 2021
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
targos
reviewed
Apr 16, 2021
Comment thread
lib/readline.js
Outdated
marsonya
reviewed
Apr 19, 2021
Comment thread
lib/readline.js
Outdated
marsonya
approved these changes
Apr 21, 2021
Trott
previously requested changes
Apr 24, 2021
Comment thread
lib/readline.js
Outdated
Trott
reviewed
Apr 24, 2021
Comment thread
lib/readline.js
Outdated
Trott
reviewed
Apr 27, 2021
Comment thread
lib/readline.js
Outdated
Trott
reviewed
May 1, 2021
Comment thread
lib/readline.js
Outdated
Trott
approved these changes
May 1, 2021
Trott
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM with or without the startup performance comments restored.
Sorry, something went wrong.
Added JSDoc typings for the `readline` lib module.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
pushed a commit
that referenced
this pull request
May 4, 2021
Added JSDoc typings for the `readline` lib module. PR-URL: #38253 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 17, 2021
Added JSDoc typings for the `readline` lib module. PR-URL: #38253 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added JSDoc typings for the readline lib module.