build: sync generation of v8_build_config.json - #38263
Merged
richardlau merged 1 commit intoApr 18, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
targos
approved these changes
Apr 16, 2021
jasnell
approved these changes
Apr 17, 2021
Trott
approved these changes
Apr 17, 2021
The contents of the `v8_build_config.json` file generated when configured with `--enable-d8` is missing entries which prevent V8's test runner from using the built `d8` binary. Sync the keys written into the file with those generated in V8's `deps/v8/BUILD.gn` file. PR-URL: nodejs#38263 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The contents of the v8_build_config.json file generated when
configured with --enable-d8 is missing entries which prevent V8's
test runner from using the built d8 binary. Sync the keys written
into the file with those generated in V8's deps/v8/BUILD.gn file.
Prior to this patch V8's test runner would fail to parse v8_build_config.json
as it was missing v8_control_flow_integrity:
$ python2 deps/v8/tools/run-tests.py --outdir ../../out/Release --progress=dots --timeout=120 mjsunit debugger message preparser Traceback (most recent call last): File "/home/rlau/sandbox/github/node/deps/v8/tools/testrunner/base_runner.py", line 283, in execute self._load_build_config(options) File "/home/rlau/sandbox/github/node/deps/v8/tools/testrunner/base_runner.py", line 428, in _load_build_config self.build_config = _do_load_build_config(outdir, options.verbose) File "/home/rlau/sandbox/github/node/deps/v8/tools/testrunner/base_runner.py", line 253, in _do_load_build_config return BuildConfig(build_config_json) File "/home/rlau/sandbox/github/node/deps/v8/tools/testrunner/base_runner.py", line 173, in __init__ self.control_flow_integrity = build_config['v8_control_flow_integrity'] KeyError: 'v8_control_flow_integrity'