doc: note the system requirements for V8 tests - #38319
Closed
DeeDeeG wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The `test-v8` Makefile target still requires Python 2, and it requires a full Xcode install on macOS. Refs: nodejs#36691
richardlau
approved these changes
Apr 20, 2021
jasnell
approved these changes
Apr 20, 2021
cjihrig
approved these changes
Apr 20, 2021
cjihrig
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGMT with some optional nits.
Sorry, something went wrong.
Comment thread
doc/guides/maintaining-V8.md
Outdated
Comment thread
doc/guides/maintaining-V8.md
Outdated
Copy link
Copy Markdown
Contributor
Author
|
I would like to document the ninja requirement, if #38299 or similar can't be merged. If someone can take a look at and give an idea if that can be merged, or feedback to make it mergeable, that would be much appreciated, and it would help to make sure this documentation is comprehensive. Thank you. |
Sorry, something went wrong.
mhdawson
approved these changes
Apr 22, 2021
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
This and the related #38299 are good to go, from my (PR author's) point of view. Thanks for the reviews. |
Sorry, something went wrong.
jasnell
pushed a commit
that referenced
this pull request
Apr 27, 2021
The `test-v8` Makefile target still requires Python 2, and it requires a full Xcode install on macOS. Refs: #36691 PR-URL: #38319 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
targos
pushed a commit
that referenced
this pull request
Apr 29, 2021
The `test-v8` Makefile target still requires Python 2, and it requires a full Xcode install on macOS. Refs: #36691 PR-URL: #38319 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
targos
pushed a commit
that referenced
this pull request
May 30, 2021
The `test-v8` Makefile target still requires Python 2, and it requires a full Xcode install on macOS. Refs: #36691 PR-URL: #38319 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
The `test-v8` Makefile target still requires Python 2, and it requires a full Xcode install on macOS. Refs: #36691 PR-URL: #38319 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
The `test-v8` Makefile target still requires Python 2, and it requires a full Xcode install on macOS. Refs: #36691 PR-URL: #38319 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
The `test-v8` Makefile target still requires Python 2, and it requires a full Xcode install on macOS. Refs: #36691 PR-URL: #38319 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test-v8 Makefile target still requires Python 2, and it requires a full Xcode install on macOS, due to its use of xcodebuild at some points.
Refs: #36691 (comment)
(Note for reviewers, a related PR: The test-v8 Makefile target also requires ninja, but I think it doesn't really need to require ninja. It actually downloads ninja as part of Google's depot_tools, but (apparently by mistake) does not put those on the PATH. See my other PR to put this copy of ninja on the PATH: #38299. I didn't add ninja as a requirement in this documentation, since I hope my PR #38299 will make that requirement go away.)