FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

timers: remove redundant unref calls by gioragutt · Pull Request #38320 · nodejs/node · GitHub

/ node Public

timers: remove redundant unref calls - #38320

Merged
Trott merged 1 commit into
nodejs:masterfrom
gioragutt:giorag/remove-redundant-unref-calls
Apr 24, 2021
ConversationCommits (1)ChecksFiles changed
Merged

timers: remove redundant unref calls#38320
Trott merged 1 commit into
nodejs:masterfrom
gioragutt:giorag/remove-redundant-unref-calls

Conversation

gioragutt commented Apr 20, 2021

Copy link
Copy Markdown
Contributor

Remove redundant calls to Timeout.unref() by passing the
ref: boolean parameter of timers/promises#setTimeout and
timers/promises#setInterval directly to Timeout constructor's
isRefed parameter.

Note: possible expansion of this PR is to apply the same isRefed
parameter from Timeout to Immediate to prevent the same redundant
Immediate.unref() call in timers/promises#setImmediate.

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 20, 2021

gioragutt commented Apr 20, 2021

Copy link
Copy Markdown
Contributor Author

Hey @jasnell, thanks for the quick review.

I have a question tho. Does my change actually change something other than a redundant call (and state changes)?

I tried looking around, but I couldn't find a reason for it to be actually meaningful 🧐 (other than of course not doing something redundant).

nodejs-github-bot commented Apr 21, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37590/

nodejs-github-bot commented Apr 21, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37595/

nodejs-github-bot commented Apr 24, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37664/

Trott approved these changes Apr 24, 2021
View reviewed changes

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM but we probably need a perf benchmark. Will start one in a moment.

Trott commented Apr 24, 2021

Copy link
Copy Markdown
Member

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1014/

Trott commented Apr 24, 2021

Copy link
Copy Markdown
Member

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1014/

No significant changes in benchmark performance.

nodejs-github-bot commented Apr 24, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37673/

timers: remove redundant unref calls
d9b56fe 
PR-URL: nodejs#38320
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Trott force-pushed the giorag/remove-redundant-unref-calls branch from 63c6270 to d9b56fe Compare April 24, 2021 22:06

Trott commented Apr 24, 2021

Copy link
Copy Markdown
Member

Landed in d9b56fe

Trott merged commit d9b56fe into nodejs:master Apr 24, 2021
targos pushed a commit that referenced this pull request Apr 29, 2021
timers: remove redundant unref calls
b3ca1b3 
PR-URL: #38320
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos mentioned this pull request May 3, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
Trott Trott approved these changes
benjamingr benjamingr approved these changes

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL