FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: fix abort in pbkdf2 by tniessen · Pull Request #38354 · nodejs/node · GitHub

/ node Public

src: fix abort in pbkdf2 - #38354

Closed
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:src-fix-crash-formatting
ConversationCommits (1)ChecksFiles changed
Closed

src: fix abort in pbkdf2#38354
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:src-fix-crash-formatting

Conversation

tniessen commented Apr 22, 2021

Copy link
Copy Markdown
Member

This should be fixed in more places where double formatting is an issue.

cc @panva

Fixes: #38341

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Apr 22, 2021
tniessen mentioned this pull request Apr 22, 2021
Closed
tniessen force-pushed the src-fix-crash-formatting branch from 35e415d to 9037ec9 Compare April 22, 2021 14:58

nodejs-github-bot commented Apr 22, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37611/

panva mentioned this pull request Apr 22, 2021
Closed

nodejs-github-bot commented Apr 22, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37614/

tniessen removed the needs-ci PRs that need a full CI run. label Apr 22, 2021

nodejs-github-bot commented Apr 22, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37617/

nodejs-github-bot commented Apr 23, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37628/

panva added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 23, 2021

nodejs-github-bot commented Apr 23, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37631/

panva pushed a commit that referenced this pull request Apr 24, 2021
src: fix abort in pbkdf2
81d7e80 
Fixes: #38341

PR-URL: #38354
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

panva commented Apr 24, 2021

Copy link
Copy Markdown
Member

Landed in 81d7e80

panva closed this Apr 24, 2021
targos pushed a commit that referenced this pull request Apr 29, 2021
src: fix abort in pbkdf2
e3538bb 
Fixes: #38341

PR-URL: #38354
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos mentioned this pull request May 3, 2021
Merged
tniessen deleted the src-fix-crash-formatting branch October 7, 2021 16:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

panva panva approved these changes
jasnell jasnell approved these changes
addaleax addaleax approved these changes
cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

crypto.pbkdf2Sync results in an abort

7 participants

Back | FazBrowse Home | New Git URL