doc: clarify DiffieHellmanGroup class docs - #38363
Closed
Linkgoron wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Make it clearer in the docs that DiffieHellmanGroup does not support changing the keys after creation.
phocodes
reviewed
Apr 23, 2021
phocodes
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
eh, I would just keep the deleted lines you deleted.
the new 4 lines isn't nessceary
Sorry, something went wrong.
bengl
reviewed
Apr 23, 2021
Comment thread
doc/api/crypto.md
Outdated
bengl
reviewed
Apr 23, 2021
Comment thread
doc/api/crypto.md
Outdated
Trott
reviewed
Apr 27, 2021
Comment thread
doc/api/crypto.md
Outdated
Trott
reviewed
Apr 27, 2021
Comment thread
doc/api/crypto.md
Outdated
Linkgoron
force-pushed
the
docs-crypto-clarify-dhg
branch
from
cb595b7 to
5473d41
Compare
April 29, 2021 08:10
jasnell
approved these changes
Apr 29, 2021
edsadr
approved these changes
May 1, 2021
jasnell
approved these changes
May 4, 2021
jasnell
pushed a commit
that referenced
this pull request
May 4, 2021
Make it clearer in the docs that DiffieHellmanGroup does not support changing the keys after creation. PR-URL: #38363 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Adrian Estrada <edsadr@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 17, 2021
Make it clearer in the docs that DiffieHellmanGroup does not support changing the keys after creation. PR-URL: #38363 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Adrian Estrada <edsadr@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 30, 2021
Make it clearer in the docs that DiffieHellmanGroup does not support changing the keys after creation. PR-URL: #38363 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Adrian Estrada <edsadr@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
Make it clearer in the docs that DiffieHellmanGroup does not support changing the keys after creation. PR-URL: #38363 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Adrian Estrada <edsadr@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
Make it clearer in the docs that DiffieHellmanGroup does not support changing the keys after creation. PR-URL: #38363 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Adrian Estrada <edsadr@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
Make it clearer in the docs that DiffieHellmanGroup does not support changing the keys after creation. PR-URL: #38363 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Adrian Estrada <edsadr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it clearer in the docs that DiffieHellmanGroup does not support changing the keys after creation (it's already mentioned in the docs - but only in the documentation for the getDiffieHellman method).