FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

debugger: fix auto-fixable lint issues in inspect library code by Trott · Pull Request #38411 · nodejs/node · GitHub

/ node Public

debugger: fix auto-fixable lint issues in inspect library code - #38411

Merged
Trott merged 2 commits into
nodejs:masterfrom
Trott:inspect-lint
Apr 28, 2021
Merged

debugger: fix auto-fixable lint issues in inspect library code#38411
Trott merged 2 commits into
nodejs:masterfrom
Trott:inspect-lint

Conversation

Trott commented Apr 26, 2021

Copy link
Copy Markdown
Member

No description provided.

github-actions Bot added inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run. labels Apr 26, 2021

Copy link
Copy Markdown
Collaborator

RaisinTen added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 27, 2021

Copy link
Copy Markdown
Collaborator

Trott added 2 commits April 28, 2021 07:02
For issues that ESLint can fix automatically, fix them.

PR-URL: nodejs#38411
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
For issues that ESLint can fix automatically, fix them.

PR-URL: nodejs#38411
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>

Trott commented Apr 28, 2021

Copy link
Copy Markdown
Member Author

Landed in 3d070d0...bdb6c59

Trott merged commit bdb6c59 into nodejs:master Apr 28, 2021
Trott deleted the inspect-lint branch April 28, 2021 14:03
targos pushed a commit that referenced this pull request Apr 29, 2021
For issues that ESLint can fix automatically, fix them.

PR-URL: #38411
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this pull request Apr 29, 2021
For issues that ESLint can fix automatically, fix them.

PR-URL: #38411
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos mentioned this pull request May 3, 2021

Trott commented Jul 19, 2021

Copy link
Copy Markdown
Member Author

@targos I don't think this should be backport-blocked. I believe this will cherry-pick cleanly to v14.x-staging and I don't think it will cause any problems. Am I wrong? (With I think only one exception, these are all space/formatting changes.)

Trott commented Jul 19, 2021

Copy link
Copy Markdown
Member Author

@targos I don't think this should be backport-blocked. I believe this will cherry-pick cleanly to v14.x-staging and I don't think it will cause any problems. Am I wrong? (With I think only one exception, these are all space/formatting changes.)

Oh, wait, that label was added weeks ago. Hey, @richardlau, this one should be cherry-pickable at this point, right? I know the subsequent ones I suggested cherry-picking used timers/promises but I think this one should be OK?

targos commented Jul 19, 2021

Copy link
Copy Markdown
Member

It didn't land cleanly when I added the label, but it's possible it does now. I just removed the label.

richardlau pushed a commit that referenced this pull request Jul 19, 2021
For issues that ESLint can fix automatically, fix them.

PR-URL: #38411
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 19, 2021
For issues that ESLint can fix automatically, fix them.

PR-URL: #38411
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>

Copy link
Copy Markdown
Member

This one cherry-picks cleanly onto v14.x-staging.

richardlau pushed a commit that referenced this pull request Jul 20, 2021
For issues that ESLint can fix automatically, fix them.

PR-URL: #38411
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
For issues that ESLint can fix automatically, fix them.

PR-URL: #38411
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
richardlau mentioned this pull request Jul 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants


Back | FazBrowse Home | New Git URL