FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

debugger: enable linter on `internal/inspector/inspect_client` by aduh95 · Pull Request #38417 · nodejs/node · GitHub

/ node Public

debugger: enable linter on internal/inspector/inspect_client - #38417

Merged
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:inspect_client-linter
May 3, 2021
Merged

debugger: enable linter on internal/inspector/inspect_client#38417
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:inspect_client-linter

Conversation

aduh95 commented Apr 26, 2021

Copy link
Copy Markdown
Contributor

No description provided.

github-actions Bot added inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run. labels Apr 26, 2021
aduh95 requested a review from Trott April 28, 2021 14:10

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM if CI is green

Copy link
Copy Markdown
Collaborator

aduh95 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label May 2, 2021
PR-URL: nodejs#38417
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
aduh95 force-pushed the inspect_client-linter branch from baf3192 to 2c0fd32 Compare May 3, 2021 11:57

aduh95 commented May 3, 2021

Copy link
Copy Markdown
Contributor Author

Landed in 2c0fd32

aduh95 merged commit 2c0fd32 into nodejs:master May 3, 2021
aduh95 deleted the inspect_client-linter branch May 3, 2021 11:58
targos pushed a commit that referenced this pull request May 3, 2021
PR-URL: #38417
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos mentioned this pull request May 3, 2021

Copy link
Copy Markdown
Member

Backport to v14.x PR: #39446

aduh95 added a commit to aduh95/node that referenced this pull request Jul 20, 2021
PR-URL: nodejs#38417
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 22, 2021
PR-URL: #38417
Backport-PR-URL: #39446
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 22, 2021
PR-URL: #38417
Backport-PR-URL: #39446
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
richardlau mentioned this pull request Jul 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL