doc: remove dependencyspecifiers frozen remark - #38434
Closed
iguessitsokay wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
the returned array is not frozen
Copy link
Copy Markdown
Member
|
@nodejs/vm |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I believe the intent was for the array to be frozen. @nodejs/modules |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
It seems better for it to be frozen, regardless of the intent or the wording in the docs. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
returned module.dependencySpecifiers array is not frozen. it is Object.isFrozen -> false and indexes are mutable. tested on a SourceTextModule instance.
Maybe freezing was the intention and this is a bug but it might be a misplacement because module.namespace is actually frozen -as expected- but with no such remark.