FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: mark querystring api as legacy by jasnell · Pull Request #38436 · nodejs/node · GitHub

/ node Public

doc: mark querystring api as legacy - #38436

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:mark-querystring-legacy
ConversationCommits (1)ChecksFiles changed
Closed

doc: mark querystring api as legacy#38436
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:mark-querystring-legacy

Conversation

jasnell commented Apr 27, 2021

Copy link
Copy Markdown
Member

Signed-off-by: James M Snell jasnell@gmail.com
Fixes: #38231

doc: mark querystring api as legacy
28b0de8 
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: nodejs#38231
github-actions Bot added doc Issues and PRs related to the documentations. querystring Issues and PRs related to the built-in querystring module. labels Apr 27, 2021
jasnell added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Apr 27, 2021

jasnell commented Apr 27, 2021

Copy link
Copy Markdown
Member Author

Simple change that shouldn't need to wait the 48 hours to land. Fast-track? Please 👍🏻

panva pushed a commit that referenced this pull request Apr 29, 2021
doc: mark querystring api as legacy
32ade69 
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #38231

PR-URL: #38436
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

panva commented Apr 29, 2021

Copy link
Copy Markdown
Member

Landed in 32ade69

panva closed this Apr 29, 2021
aduh95 removed the fast-track PRs that do not need to wait for 48 hours to land. label Apr 29, 2021
targos pushed a commit that referenced this pull request Apr 29, 2021
doc: mark querystring api as legacy
3cbfde1 
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #38231

PR-URL: #38436
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos mentioned this pull request May 3, 2021
Merged
targos pushed a commit that referenced this pull request May 30, 2021
doc: mark querystring api as legacy
6334898 
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #38231

PR-URL: #38436
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Jun 5, 2021
doc: mark querystring api as legacy
9c9f31a 
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #38231

PR-URL: #38436
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Jun 5, 2021
doc: mark querystring api as legacy
6faa1fa 
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #38231

PR-URL: #38436
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
doc: mark querystring api as legacy
839e8d1 
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #38231

PR-URL: #38436
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
richardlau richardlau approved these changes
aduh95 aduh95 approved these changes
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. querystring Issues and PRs related to the built-in querystring module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Deprecate the old querystring in favor of URLSearchParams?

6 participants

Back | FazBrowse Home | New Git URL