meta: post comment when pr labeled fast-track - #38446
Conversation
Sorry, something went wrong.
|
@nodejs/build ... my github actions skill is still fairly weak so I'd appreciate if someone could help verify this. |
Sorry, something went wrong.
|
Unfortunately you cannot test changes to a workflow that uses the pull_request_target event without landing them on a branch and opening a PR against that branch |
Sorry, something went wrong.
|
Maybe this should be merged with .github/workflows/comment-stalled.yml and called something like auto-comments.yml? I suppose we may want to add more automation in the future, adding a new workflow each time seems unnecessary. |
Sorry, something went wrong.
Signed-off-by: James M Snell <jasnell@gmail.com>
targos
left a comment
There was a problem hiding this comment.
LGTM. The file could be renamed to "comment-labeled.yml" or "labeled.yml"
Sorry, something went wrong.
mmarchini
left a comment
There was a problem hiding this comment.
Personally I would prefer the files to remain separate, merging them doesn't bring any value because there's no reuse between the two flows, and the only thing they share is the labeled event for PRs. Plus merging the files increase the complexity because now we need an extra condition in the if statement to skip the fast track job on issues.
I don't feel strong enough about it to ask to go back to separate files though.
Sorry, something went wrong.
|
@mmarchini ... I don't know if I was doing something wrong or what, but I actually had a difficult time getting the fastTrack workflow to run consistently when it was in a separate file.... and by that I mean in testing on my personal fork, the stalled label workflow would run but the fast track wouldn't. The only way I was able to get both to run consistently was putting them both in a single workflow file. Not opposed to separating them back out into separate files if that works and is preferred but let's go ahead and land this PR and we can separate them out later if necessary in another commit. |
Sorry, something went wrong.
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #38446 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #38446 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #38446 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #38446 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #38446 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #38446 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Automatically adds a comment when a pull requests is labeled "fast-track"
Signed-off-by: James M Snell jasnell@gmail.com