async_hooks: merge resource_symbol with owner_symbol - #38468
Closed
RaisinTen wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
jasnell
approved these changes
Apr 29, 2021
addaleax
approved these changes
Apr 30, 2021
Comment thread
lib/internal/async_hooks.js
Outdated
Comment thread
lib/internal/async_hooks.js
Outdated
RaisinTen
commented
Apr 30, 2021
Comment thread
src/async_wrap.cc
Outdated
RaisinTen
commented
Apr 30, 2021
Comment thread
src/async_wrap.cc
Outdated
Trott
approved these changes
May 2, 2021
Qard
reviewed
May 10, 2021
Comment thread
src/async_wrap.cc
Outdated
Signed-off-by: Darshan Sen <darshan.sen@postman.com>
RaisinTen
force-pushed
the
async_hooks/merge-resource_symbol-with-owner_symbol
branch
from
aa99773 to
8fa2b28
Compare
July 26, 2021 06:31
This comment has been minimized.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
addaleax
approved these changes
Jul 26, 2021
addaleax
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
👍
I know that the constructor name checks may seem a bit icky here, but I think in the big picture doing this is definitely worth it 👍
Sorry, something went wrong.
This comment has been minimized.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
approved these changes
Jul 26, 2021
Copy link
Copy Markdown
Member
Author
|
cc @nodejs/async_hooks if anyone else would also like to take a look. |
Sorry, something went wrong.
benjamingr
approved these changes
Jul 27, 2021
jasnell
pushed a commit
that referenced
this pull request
Jul 28, 2021
Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #38468 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
RaisinTen
deleted the
async_hooks/merge-resource_symbol-with-owner_symbol
branch
July 31, 2021 04:54
danielleadams
pushed a commit
that referenced
this pull request
Aug 16, 2021
Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #38468 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Copy link
Copy Markdown
Contributor
|
This breaks AsyncLocalStorage for TCP/TLS sockets. See #40693. |
Sorry, something went wrong.
This was referenced Jun 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per this TODO comment:
node/lib/internal/async_hooks.js
Lines 182 to 183 in 6ca785b