FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v16.x] deps: V8: Add Power10 to the supported list and enable related features by miladfarca · Pull Request #38489 · nodejs/node · GitHub

/ node Public

[v16.x] deps: V8: Add Power10 to the supported list and enable related features - #38489

Closed
miladfarca wants to merge 2 commits into
nodejs:v16.x-stagingfrom
miladfarca:p10-port
ConversationCommits (2)ChecksFiles changed
Closed

[v16.x] deps: V8: Add Power10 to the supported list and enable related features#38489
miladfarca wants to merge 2 commits into
nodejs:v16.x-stagingfrom
miladfarca:p10-port

Conversation

miladfarca commented Apr 30, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Please note that enum values are slightly different from V8 upstream, i.e PPC_POWER10 instead of kPPCPower10.
We also have SIMD enabled upstream which will not be backported here.

Refs: v8/v8@530080c

github-actions Bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v16.x v8 engine Issues and PRs related to the V8 dependency. labels Apr 30, 2021

nodejs-github-bot commented Apr 30, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37849/

nodejs-github-bot commented Apr 30, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37854/

nodejs-github-bot commented May 1, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37860/

miladfarca commented May 1, 2021

Copy link
Copy Markdown
Contributor Author

@richardlau is test-crypto-timing-safe-equal-benchmarks flaky on s390? as my changes are ppc specific.

richardlau commented May 1, 2021

Copy link
Copy Markdown
Member

@miladfarca The test has been failing a lot recently on s390x: #38226
It’s not clear as to what has changed to make the test fail and whether or not there is an underlying defect.

miladfarca commented May 1, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Thanks for the link. Yes some other tests seem to be flaky too i.e inspector-cli/test-inspector-cli-address failed on AIX and inspector-cli/test-inspector-cli-pid on ppc on the previous runs.

nodejs-github-bot commented May 1, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37864/

nodejs-github-bot commented May 3, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37888/

nodejs-github-bot commented May 3, 2021 •
edited by richardlau
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37889/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/3972/

miladfarca mentioned this pull request May 3, 2021
Merged

aduh95 commented May 3, 2021

Copy link
Copy Markdown
Contributor

Should this target master instead of v16.x-staging?

miladfarca commented May 3, 2021

Copy link
Copy Markdown
Contributor Author

@aduh95 There is already a PR open to update V8 on master, I've request a cherry pick: #38273

jasnell changed the title deps: V8: Add Power10 to the supported list and enable related features [v16.x] deps: V8: Add Power10 to the supported list and enable related features May 4, 2021
jasnell removed the needs-ci PRs that need a full CI run. label May 4, 2021
mhdawson approved these changes May 6, 2021
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

nodejs-github-bot commented May 14, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38084/

miladfarca commented May 14, 2021

Copy link
Copy Markdown
Contributor Author

@richardlau Would you please help with landing this as well?
Also is there a way to only re-run the AIX test? Failure shouldn't be related to this PR.

nodejs-github-bot commented May 14, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38090/

richardlau pushed a commit that referenced this pull request May 14, 2021
deps: V8: cherry-pick 530080c44af2
f31a611 
    Original commit message:
    ```
    PPC: Add Power10 to the supported list and enable related features

    This CL adds Power10 recognition to Linux, AIX as well as IBMi.

    Enabled features include:
    MODULO
    FPR_GPR_MOV
    SIMD
    LWSYNC
    ISELECT
    VSX

    Change-Id: Ifc337e6497a3efe9697bcf03063a2b94471f96e9
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2855041
    Reviewed-by: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: Junliang Yan <junyan@redhat.com>
    Reviewed-by: Vasili Skurydzin <vasili.skurydzin@ibm.com>
    Commit-Queue: Milad Fa <mfarazma@redhat.com>
    Cr-Commit-Position: refs/heads/master@{#74279}
    ```

Refs: v8/v8@530080c

PR-URL: #38489
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ash Cripps <acripps@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

richardlau commented May 14, 2021

Copy link
Copy Markdown
Member

Landed in f31a611.

richardlau closed this May 14, 2021
targos mentioned this pull request May 18, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
Trott Trott approved these changes
cjihrig cjihrig approved these changes
richardlau richardlau approved these changes
gireeshpunathil gireeshpunathil approved these changes
+3 more reviewers
targos targos approved these changes
mhdawson mhdawson approved these changes
AshCripps AshCripps approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL