FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs: workload name corrected as per the latest VS Installer by MrJithil · Pull Request #38500 · nodejs/node · GitHub

/ node Public

docs: workload name corrected as per the latest VS Installer - #38500

Closed
MrJithil wants to merge 1 commit into
nodejs:masterfrom
MrJithil:docs/vcWorkloadNameCorrection
ConversationCommits (1)ChecksFiles changed
Closed

docs: workload name corrected as per the latest VS Installer#38500
MrJithil wants to merge 1 commit into
nodejs:masterfrom
MrJithil:docs/vcWorkloadNameCorrection

Conversation

MrJithil commented May 1, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

The windows local machine setup guide suggests installing the prerequisites "Visual C++ build tools" workload from the visual studio build tool installer. But, there is not workload named "Visual C++ build tools" in the current installer. Instead, maybe the Microsoft team renamed that to just "C++ build tools" in the workload list.
Correcting the workload name as per the current installer list.

Reference:

github-actions Bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels May 1, 2021

MrJithil commented May 1, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

@targos I don't have the authorization to merge this pull request. Could you please help me to run the work flow?

edsadr self-requested a review May 1, 2021 21:07
aduh95 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label May 2, 2021

MrJithil commented May 3, 2021

Copy link
Copy Markdown
Member Author

@jasnell Could you please help me to merge this PR? I don't have merge permission.

jasnell commented May 3, 2021

Copy link
Copy Markdown
Member

@MrJithil ... the PR will be merged shortly. For most PRS there is a minimum 48 hour waiting time for reviews. We do have a fast-track option but there's only about an hour left before the 48 hours on this PR is up so it's better to just wait.

pd4d10 mentioned this pull request May 4, 2021
Closed

MrJithil commented May 4, 2021

Copy link
Copy Markdown
Member Author

@jasnell As we discussed yesterday, can we merge this pull request now?

jasnell commented May 4, 2021

Copy link
Copy Markdown
Member

Landed in 9df904b

jasnell closed this May 4, 2021
jasnell pushed a commit that referenced this pull request May 4, 2021
doc: corrected workload name as per the latest VS Installer
9df904b 
PR-URL: #38500
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request May 17, 2021
doc: corrected workload name as per the latest VS Installer
9e10e1a 
PR-URL: #38500
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos mentioned this pull request May 18, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
Trott Trott approved these changes
+2 more reviewers
edsadr edsadr approved these changes
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL