FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: make workers messaging more resilient by juanarbol · Pull Request #38510 · nodejs/node · GitHub

/ node Public

src: make workers messaging more resilient - #38510

Closed
juanarbol wants to merge 2 commits into
nodejs:masterfrom
juanarbol:juan/fix-worker-crash
ConversationCommits (2)ChecksFiles changed
Closed

src: make workers messaging more resilient#38510
juanarbol wants to merge 2 commits into
nodejs:masterfrom
juanarbol:juan/fix-worker-crash

Conversation

juanarbol commented May 3, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes: #38499

github-actions Bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels May 3, 2021
juanarbol added the worker Issues and PRs related to Worker support. label May 3, 2021

jasnell commented May 3, 2021

Copy link
Copy Markdown
Member

I would suggest that moveMessagePortToContext() should throw earlier if it's given a MessagePort that is already closed, or in the process of closing such that the execution doesn't even get this far along.

jasnell requested a review from addaleax May 3, 2021 14:08
addaleax approved these changes May 3, 2021
View reviewed changes

addaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good with a test :)

Comment thread src/node_messaging.cc Outdated
addaleax reviewed May 3, 2021
View reviewed changes
Comment thread src/node_errors.h Outdated
Revert "worker: remove ERR_CLOSED_MESSAGE_PORT"
051741c 
This reverts commit 73370b4.

The unit test is preserved to make sure it does not break
nodejs#26463 again.
juanarbol force-pushed the juan/fix-worker-crash branch from c4233b4 to a73a147 Compare May 3, 2021 20:16
juanarbol marked this pull request as ready for review May 3, 2021 20:16
Trott requested changes May 3, 2021
View reviewed changes

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Whoops, just noticed that the error code was put back but it wasn't removed from the legacy section of the errors.md doc. That should probably happen, yeah?

juanarbol commented May 3, 2021

Copy link
Copy Markdown
Member Author

Whoops, just noticed that the error code was put back but it wasn't removed from the legacy section of the errors.md doc. That should probably happen, yeah?

Yeap, totally, do you think I should add some extra data to the history of the error?

juanarbol force-pushed the juan/fix-worker-crash branch 3 times, most recently from 6eea0f2 to 40f807a Compare May 3, 2021 20:46
Trott reviewed May 3, 2021
View reviewed changes
Comment thread doc/api/errors.md Outdated
juanarbol force-pushed the juan/fix-worker-crash branch from 40f807a to f7269dc Compare May 4, 2021 17:37
jasnell removed the needs-ci PRs that need a full CI run. label May 4, 2021

This comment has been minimized.

Sign in to view
jasnell added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label May 4, 2021

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

nodejs-github-bot commented May 6, 2021 •
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37936/ 💚

jasnell commented May 6, 2021

Copy link
Copy Markdown
Member

Landed in bed947b...75073ab

jasnell closed this May 6, 2021
jasnell pushed a commit that referenced this pull request May 6, 2021
Revert "worker: remove ERR_CLOSED_MESSAGE_PORT"
b373a2c 
This reverts commit 73370b4.

The unit test is preserved to make sure it does not break
#26463 again.

PR-URL: #38510
Fixes: #38499
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request May 6, 2021
src: make workers messaging more resilient
75073ab 
PR-URL: #38510
Fixes: #38499
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request May 17, 2021
Revert "worker: remove ERR_CLOSED_MESSAGE_PORT"
070ee4b 
This reverts commit 73370b4.

The unit test is preserved to make sure it does not break
#26463 again.

PR-URL: #38510
Fixes: #38499
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request May 17, 2021
src: make workers messaging more resilient
bfec80f 
PR-URL: #38510
Fixes: #38499
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos mentioned this pull request May 18, 2021
Merged
targos pushed a commit that referenced this pull request May 30, 2021
Revert "worker: remove ERR_CLOSED_MESSAGE_PORT"
a2c6b5f 
This reverts commit 73370b4.

The unit test is preserved to make sure it does not break
#26463 again.

PR-URL: #38510
Fixes: #38499
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request May 30, 2021
src: make workers messaging more resilient
016e46a 
PR-URL: #38510
Fixes: #38499
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
Revert "worker: remove ERR_CLOSED_MESSAGE_PORT"
c778c71 
This reverts commit 73370b4.

The unit test is preserved to make sure it does not break
#26463 again.

PR-URL: #38510
Fixes: #38499
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
src: make workers messaging more resilient
3ceb133 
PR-URL: #38510
Fixes: #38499
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
Revert "worker: remove ERR_CLOSED_MESSAGE_PORT"
d624566 
This reverts commit 73370b4.

The unit test is preserved to make sure it does not break
#26463 again.

PR-URL: #38510
Fixes: #38499
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
src: make workers messaging more resilient
0de6270 
PR-URL: #38510
Fixes: #38499
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
Revert "worker: remove ERR_CLOSED_MESSAGE_PORT"
2c66305 
This reverts commit 73370b4.

The unit test is preserved to make sure it does not break
#26463 again.

PR-URL: #38510
Fixes: #38499
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jun 11, 2021
src: make workers messaging more resilient
bc2111c 
PR-URL: #38510
Fixes: #38499
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
juanarbol deleted the juan/fix-worker-crash branch August 26, 2021 17:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
aduh95 aduh95 left review comments
jasnell jasnell approved these changes
Trott Trott approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. worker Issues and PRs related to Worker support.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

worker_threads.moveMessagePortToContext results in an abort

6 participants

Back | FazBrowse Home | New Git URL