FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test,repl: fix tests when inspector is disabled by aduh95 · Pull Request #38564 · nodejs/node · GitHub

/ node Public

test,repl: fix tests when inspector is disabled - #38564

Merged
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:fix-repl-test
May 9, 2021
ConversationCommits (1)ChecksFiles changed
Merged

test,repl: fix tests when inspector is disabled#38564
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:fix-repl-test

Conversation

aduh95 commented May 6, 2021

Copy link
Copy Markdown
Contributor

Fixes: #38558

github-actions Bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 6, 2021

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

nodejs-github-bot commented May 6, 2021 •
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37946/ 💚

aduh95 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label May 7, 2021
jasnell added fast-track PRs that do not need to wait for 48 hours to land. and removed needs-ci PRs that need a full CI run. labels May 7, 2021

github-actions Bot commented May 7, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @jasnell. Please 👍 to approve.

Trott commented May 8, 2021

Copy link
Copy Markdown
Member

I thought we had a no-inspector build in CI, but I guess we don't?

aduh95 removed the fast-track PRs that do not need to wait for 48 hours to land. label May 9, 2021
test,repl: fix tests when inspector is disabled
7c8a608 
Fixes: nodejs#38558

PR-URL: nodejs#38564
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

aduh95 commented May 9, 2021

Copy link
Copy Markdown
Contributor Author

Landed in 7c8a608

aduh95 merged commit 7c8a608 into nodejs:master May 9, 2021
aduh95 deleted the fix-repl-test branch May 9, 2021 07:19
targos pushed a commit that referenced this pull request May 17, 2021
test,repl: fix tests when inspector is disabled
24472d9 
Fixes: #38558

PR-URL: #38564
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos mentioned this pull request May 18, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
Trott Trott approved these changes
addaleax addaleax approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

>=node-16.0.0: failed test # 12 in parallel/test-repl-history-navigation

6 participants

Back | FazBrowse Home | New Git URL