build: add lto build to CI - #38567
Closed
gengjiawen wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
jasnell
approved these changes
May 17, 2021
Copy link
Copy Markdown
Member
|
The workflow fails early: Run python configure.py --enable-lto && make -C out/Release v8_snapshot INFO: configure completed successfully make: *** out/Release: No such file or directory. Stop. Error: Process completed with exit code 2. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Yeap. Mainly to verify this #38570 (comment). From feedback, it looks like it's a bug in gcc 9.3 . |
Sorry, something went wrong.
gengjiawen
force-pushed
the
lto_test
branch
6 times, most recently
from
bd8f423 to
f396bde
Compare
May 24, 2021 04:11
gengjiawen
force-pushed
the
lto_test
branch
2 times, most recently
from
86ddf3a to
8df9eb4
Compare
May 27, 2021 01:57
Copy link
Copy Markdown
Member
|
I'm not sure it's worth spending >100 min of computing power on every commit for this :( |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Is there a way only run it in tag release ? |
Sorry, something went wrong.
gengjiawen
commented
May 27, 2021
Comment thread
.github/workflows/misc.yml
Outdated
richardlau
reviewed
May 27, 2021
Comment thread
.github/workflows/daily.yml
Outdated
targos
reviewed
May 27, 2021
Comment thread
.github/workflows/daily.yml
Outdated
Comment thread
.github/workflows/daily.yml
Outdated
gengjiawen
added a commit
that referenced
this pull request
May 28, 2021
PR-URL: #38567 Reviewed-By: James M Snell <jasnell@gmail.com>
Copy link
Copy Markdown
Member
|
Belated LGTM |
Sorry, something went wrong.
danielleadams
pushed a commit
that referenced
this pull request
May 31, 2021
PR-URL: #38567 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
richardlau
pushed a commit
that referenced
this pull request
Jul 16, 2021
PR-URL: #38567 Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Jul 19, 2021
PR-URL: #38567 Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Jul 20, 2021
PR-URL: #38567 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prevent regression like #38335