FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: add missing torque output sources by richardlau · Pull Request #38576 · nodejs/node · GitHub

/ node Public

build: add missing torque output sources - #38576

Merged
richardlau merged 1 commit into
nodejs:masterfrom
richardlau:non-optimized-debug
May 7, 2021
ConversationCommits (1)ChecksFiles changed
Merged

build: add missing torque output sources#38576
richardlau merged 1 commit into
nodejs:masterfrom
richardlau:non-optimized-debug

Conversation

richardlau commented May 6, 2021

Copy link
Copy Markdown
Member

The torque_generated_definitions target is missing some torque
generated files in its sources list when compared to the equivalent
target in V8's BUILD.gn.

Fixes: #38571

Syncs our gyp file with

node/deps/v8/BUILD.gn

Lines 1618 to 1625 in e46c680

foreach(file, torque_files) {
filetq = string_replace(file, ".tq", "-tq")
sources += [
"$target_gen_dir/torque-generated/$filetq-inl.inc",
"$target_gen_dir/torque-generated/$filetq.cc",
"$target_gen_dir/torque-generated/$filetq.inc",
]
}

cc @john-yan @nodejs/v8-update

github-actions Bot added the needs-ci PRs that need a full CI run. label May 6, 2021
richardlau mentioned this pull request May 6, 2021
Closed

This comment has been minimized.

Sign in to view
richardlau added the build Issues and PRs related to build files or the CI. label May 6, 2021

nodejs-github-bot commented May 6, 2021 •
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37953/ 💚

richardlau added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label May 6, 2021
jasnell added fast-track PRs that do not need to wait for 48 hours to land. and removed needs-ci PRs that need a full CI run. labels May 7, 2021

github-actions Bot commented May 7, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @jasnell. Please 👍 to approve.

build: add missing torque output sources
184e0f7 
The `torque_generated_definitions` target is missing some torque
generated files in its sources list when compared to the equivalent
target in V8's BUILD.gn.

PR-URL: nodejs#38576
Fixes: nodejs#38571
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
richardlau force-pushed the non-optimized-debug branch from e5b7987 to 184e0f7 Compare May 7, 2021 18:11

richardlau commented May 7, 2021

Copy link
Copy Markdown
Member Author

Landed in 184e0f7.

richardlau merged commit 184e0f7 into nodejs:master May 7, 2021
richardlau deleted the non-optimized-debug branch May 7, 2021 18:11
richardlau mentioned this pull request May 11, 2021
Merged
targos pushed a commit that referenced this pull request May 17, 2021
build: add missing torque output sources
10aaf30 
The `torque_generated_definitions` target is missing some torque
generated files in its sources list when compared to the equivalent
target in V8's BUILD.gn.

PR-URL: #38576
Fixes: #38571
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos mentioned this pull request May 18, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
addaleax addaleax approved these changes
cjihrig cjihrig approved these changes
gengjiawen gengjiawen approved these changes
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Node.js would not compile with --debug --v8-non-optimized-debug

7 participants

Back | FazBrowse Home | New Git URL