test: improve coverage of lib/readline.js - #38646
Merged
nodejs-github-bot merged 1 commit intoMay 12, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
pd4d10
force-pushed
the
patch-test-readline
branch
from
5917371 to
7489b03
Compare
May 12, 2021 09:25
jasnell
approved these changes
May 12, 2021
Trott
approved these changes
May 13, 2021
mhdawson
approved these changes
May 14, 2021
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Hi, thanks for submitting the code. could you resolve git conflicts? @pd4d10 |
Sorry, something went wrong.
Lxxyx
approved these changes
Jun 11, 2021
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
VoltrexKeyva
approved these changes
Sep 3, 2021
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
pd4d10
force-pushed
the
patch-test-readline
branch
from
9328554 to
2881cb9
Compare
April 3, 2022 17:21
Copy link
Copy Markdown
Contributor
|
This needs a rebase |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open. |
Sorry, something went wrong.
pd4d10
force-pushed
the
patch-test-readline
branch
from
2881cb9 to
9b9edd6
Compare
May 6, 2024 05:34
Copy link
Copy Markdown
Contributor
Author
@aduh95 Updated |
Sorry, something went wrong.
aduh95
approved these changes
May 10, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
May 12, 2024
PR-URL: #38646 Refs: https://coverage.nodejs.org/coverage-16e00a15deafdad0/lib/readline.js.html#L441 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 17, 2024
PR-URL: #38646 Refs: https://coverage.nodejs.org/coverage-16e00a15deafdad0/lib/readline.js.html#L441 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
soophoo
pushed a commit
to soophoo/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#38646 Refs: https://coverage.nodejs.org/coverage-16e00a15deafdad0/lib/readline.js.html#L441 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs:
https://coverage.nodejs.org/coverage-16e00a15deafdad0/lib/readline.js.html#L441
https://coverage.nodejs.org/coverage-16e00a15deafdad0/lib/readline.js.html#L625
https://coverage.nodejs.org/coverage-16e00a15deafdad0/lib/readline.js.html#L634