doc: add ESM code examples in url.md - #38651
Closed
aduh95 wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Switching to import is good, but I think removing import/require is bad. Like I said, it's not clear where these methods from. When I first saw new URL('file:///C:/path/').pathname; // Incorrect: /C:/path/
fileURLToPath('file:///C:/path/'); // Correct: C:\path\ (Windows)I really don't know how to use fileURLToPath,
It doesn't make sense to remove these imports. check https://nodejs.org/api/child_process.html, every example has require('child_process') it's very clear how to use it. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
worker_threads /fs / assert/dns has those imports as well, I don't think people care much it's import or require |
Sorry, something went wrong.
jasnell
approved these changes
May 12, 2021
shisama
approved these changes
May 13, 2021
Copy link
Copy Markdown
Contributor
|
Yes, with pleasure. |
Sorry, something went wrong.
jasnell
pushed a commit
that referenced
this pull request
May 14, 2021
PR-URL: #38651 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 17, 2021
PR-URL: #38651 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #38645, removing use of require or adding import equivalents where it makes sense.
@fisker what do you think?